Introduce Join class in QueryBuilder

[BenMorel]

Q	A
Type	improvement
BC Break	yes
Fixed issues	none

Summary

This is a subset of #3829, that only replaces the associative array for the JOIN part with a proper class.
Note that this change alone doesn't solve the phpstan issue.

[morozov]

Code-wise looks good! Do you want to try and remove the whitelisted PHPStan error, then squash everything?

[BenMorel]

Do you want to try and remove the whitelisted PHPStan error

Already tried it, still the same error.

then squash everything?

Squashed!

[morozov]

BC Break: yes

Not sure where it is. Should it be documented in upgrade notes then?

Already tried it, still the same error.

This is surprising. It may make sense to update the reported issue since unlike the earlier implementation, the proposed uses better-defined types.

[BenMorel]

Not sure where it is. Should it be documented in upgrade notes then?

It's in getQueryPart(s)(). The returned array is not compatible with the previous one. I'd rather plan to remove these methods altogether, and document it then.

[BenMorel]

This is surprising. It may make sense to update the reported issue since unlike the earlier implementation, the proposed uses better-defined types.

Strangely, now it doesn't happen in the sandbox anymore:
https://phpstan.org/r/8dbea40a-8f10-441a-8e83-cdbdceb8bb88

But it definitely does in our codebase. TBH, I'd better avoid wasting more time on this phpstan bug, and invest it in improving this codebase instead. Once all the changes will be merged, the error will be gone, as you can see in #3829 (d8eecdf).

[morozov]

Thanks, @BenMorel!

[morozov]

I'd better avoid wasting more time on this phpstan bug

diff --git a/lib/Doctrine/DBAL/Query/QueryBuilder.php b/lib/Doctrine/DBAL/Query/QueryBuilder.php
index 00eba6b55..f20e466d9 100644
--- a/lib/Doctrine/DBAL/Query/QueryBuilder.php
+++ b/lib/Doctrine/DBAL/Query/QueryBuilder.php
@@ -1298,8 +1298,8 @@ class QueryBuilder
         $sql = '';
 
         if (isset($this->sqlParts['join'][$fromAlias])) {
+            /** @var Join $join */
             foreach ($this->sqlParts['join'][$fromAlias] as $join) {
-                /** @var Join $join */
                 if (array_key_exists($join->alias, $knownAliases)) {
                     throw NonUniqueAlias::new($join->alias, array_keys($knownAliases));
                 }

Not a bug but documented behavior: phpstan/phpstan#466 (comment).

[BenMorel]

@morozov Well spotted! Fixed in #3835.