Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce From class in QueryBuilder #3833

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Introduce From class in QueryBuilder #3833

merged 1 commit into from
Jan 21, 2020

Conversation

BenMorel
Copy link
Contributor

Q A
Type improvement
BC Break yes
Fixed issues none

Summary

Continuing the work started in #3830, this time with a From object.

@BenMorel BenMorel requested a review from morozov January 19, 2020 00:00
morozov
morozov reviewed Jan 19, 2020
View reviewed changes
lib/Doctrine/DBAL/Query/From.php Outdated Show resolved Hide resolved
lib/Doctrine/DBAL/Query/QueryBuilder.php Show resolved Hide resolved
lib/Doctrine/DBAL/Query/QueryBuilder.php Outdated Show resolved Hide resolved
lib/Doctrine/DBAL/Query/QueryBuilder.php Outdated Show resolved Hide resolved
@BenMorel
Copy link
Contributor Author

@morozov All good for me here. Any more comments?

@morozov
Copy link
Member

morozov commented Jan 21, 2020

Any more comments?

Almos there. Please document the breaking changes: the $table argument is required in insert(), update() and delete() statements, aliases no longer supported. Maybe something else I'm missing?

@BenMorel
Copy link
Contributor Author

Please document the breaking changes

Done in 7c2fc70

Maybe something else I'm missing?

Same as #3830 : getQueryPart(s)(). I'll document this once the QueryParts object is introduced (next PR, once this one is merged).

@morozov
Copy link
Member

morozov commented Jan 21, 2020

All good. Please squash.

@morozov morozov added this to the 4.0.0 milestone Jan 21, 2020
@morozov morozov self-assigned this Jan 21, 2020
@BenMorel
Copy link
Contributor Author

@morozov Done!

@morozov morozov merged commit 22854d2 into doctrine:master Jan 21, 2020
@morozov
Copy link
Member

morozov commented Jan 21, 2020

Thanks @BenMorel! I like the pace.

@BenMorel BenMorel mentioned this pull request Jan 21, 2020
Merged
@morozov morozov mentioned this pull request Aug 23, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees

@morozov morozov

Labels
BC Break Improvement QueryBuilder Strict Typing
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenMorel @morozov