Migrate jobs away from Travis to Github Actions #4310

greg0ire · 2020-09-28T15:10:31Z

Todo:

greg0ire · 2020-09-29T12:46:49Z

@localheinz @bendavies please also review 🙏

.github/workflows/continuous-integration.yml

bendavies · 2020-09-29T13:03:09Z

very nice

greg0ire · 2020-09-29T13:10:11Z

tests/travis/install-sqlsrv-dependencies.sh

-curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
-curl https://packages.microsoft.com/config/ubuntu/16.04/prod.list | sudo tee /etc/apt/sources.list.d/mssql.list
-sudo apt-get update
-ACCEPT_EULA=Y sudo apt-get install -qy msodbcsql17 unixodbc unixodbc-dev libssl1.0.0


I wrote the equivalent of this at first, only to see that all the packages above were already present somehow.

morozov · 2020-09-29T18:28:46Z

This is impressive work, @greg0ire!

greg0ire · 2020-09-29T18:45:53Z

The issue with the PG 9.2 is that we don't have the logs of the service… Let me try to remove the healtcheck, that way we can proceed with any next step we want. I will add a step that waits 1 mn, and then another that shows the logs.

greg0ire · 2020-09-29T18:52:56Z

Well… I didn't expect this! Looks like the issue is with the healthcheck itself!
UPD: That would be because pg_isready was introduced in 9.3. Before this PR, it was only used for PostgreSQL 11. There was just no healthcheck for lower versions. Not sure what we should do, but let's try to see if it works when I remove the step that sleeps for 1 mn.

greg0ire · 2020-09-29T19:07:34Z

Works like a charm w/o the delay too… maybe we should merge as is (after a squash and some cleanup of the commented out code of course). If we get issues down the line, we can still add the healtcheck back, and mark the 9.2 build as not required until we figure it out.

bendavies · 2020-09-29T19:27:33Z

@greg0ire pg_isready was added in postgresql 9.3

greg0ire · 2020-09-29T19:34:59Z

Yup that's what I figured in #4310 (comment) 😄

bendavies · 2020-09-29T19:47:03Z

Ah sorry!
This should work:

--health-cmd "pg_isready || psql -U postgres -c 'SELECT 1'"

greg0ire · 2020-10-15T06:17:00Z

Ah I think I'm onto something!

greg0ire · 2020-10-15T06:33:02Z

Yaaaaay! +2% coverage! I turned on assertions, it's still code that is better off being run than not run: what if an assertion is wrong?

greg0ire · 2020-10-15T07:01:18Z

I added a todo item to reduce the number of builds according to your recommendation "All other supported PHP versions (7.1, 7.3, nightly), test each driver with the latest version of the platform." @morozov , but please note that MariaDB is not tested with 7.3, so maybe there are more todo items to add

greg0ire · 2020-10-15T07:09:23Z

I think that will not change things much. Please tell me precisely what rule I should apply to decrease the number of builds. Should we maybe have some rule like "test the lowest supported platform version, and the 3 latest minor versions, but not all versions in between"?

It should be faster, and will result in one fewer CI platform to maintain.

morozov · 2020-10-15T16:08:14Z

I turned on assertions, it's still code that is better off being run than not run: what if an assertion is wrong?

Yeah. CI is the right place to have them enabled.

Please tell me precisely what rule I should apply to decrease the number of builds. Should we maybe have some rule like "test the lowest supported platform version, and the 3 latest minor versions, but not all versions in between"?

I didn't realize we have that many different MariaDB versions tested, so the existing 12 jobs do not technically violate the approach defined in #3347 (comment). I believe we can leave them as is for now and rely on support for some older versions being dropped in 3.0.x.

[…] please note that MariaDB is not tested with 7.3, so maybe there are more todo items to add

I wouldn't bother about adding new jobs right now unless they provide additional code coverage or reveal new issues.

greg0ire · 2020-10-15T16:10:26Z

Ok, I will now fiddle with the branch settings and finally merge this! 🎉

morozov · 2020-10-15T16:14:01Z

Should we maybe have some rule like "test the lowest supported platform version, and the 3 latest minor versions, but not all versions in between"?

Actually what we could do later as optimization is to reduce the set of specific platform versions being tested to the necessary minimum that our code is aware of. I.e. test the oldest version, the newest version, and all versions for which we have version-specific code. For MariaDB, it would be 10.0 (oldest), 10.2 (MariaDb1027Platform), and 10.5 (newest).

If this works, we may want to combine this and the previous rule in a documentation article.

morozov · 2020-10-15T16:28:31Z

Awesome work, @greg0ire. You rock!

thomasrockhu · 2020-10-15T16:33:42Z

Seriously awesome work @greg0ire for the upload-artifact stuff!

bendavies · 2020-10-17T17:02:50Z

.github/workflows/continuous-integration.yml

+ with:
+ name: "${{ github.job }}-${{ matrix.mariadb-version }}-${{ matrix.extension }}-${{ matrix.php-version }}.coverage"
+ path: "coverage.xml"
+


extra new line here ;)

@bendavies please send a PR :P

bendavies · 2020-10-17T17:04:23Z

.github/workflows/continuous-integration.yml

+
+

bendavies · 2020-10-17T17:06:24Z

seriously impressive work! 💪

@morozov

Release [2.11.2](https://github.com/doctrine/dbal/milestone/81) 2.11.2 ====== - Total issues resolved: **5** - Total pull requests resolved: **16** - Total contributors: **10** Static Analysis --------------- - [4353: Update Psalm to 3.17.2 and lock the version used with GitHub Actions](doctrine#4353) thanks to @morozov - [4348: Bump Psalm level to 3](doctrine#4348) thanks to @morozov - [4332: Static analysis improvements](doctrine#4332) thanks to @morozov - [4319: Bump Psalm level to 4](doctrine#4319) thanks to @morozov Code Style ---------- - [4346: Minor CS improvement - use ::class for TestCase::expectException input](doctrine#4346) thanks to @mvorisek - [4344: Static analysis workflow](doctrine#4344) thanks to @greg0ire - [4340: Modernize existing ga](doctrine#4340) thanks to @greg0ire - [4309: Use cache action v2](doctrine#4309) thanks to @greg0ire - [4305: Move website config to default branch](doctrine#4305) thanks to @SenseException Improvement,Prepared Statements ------------------------------- - [4341: Add Statement::fetchAllIndexedAssociative() and ::iterateIndexedAssociative()](doctrine#4341) thanks to @morozov and @ZaneCEO - [4338: Add Statement::fetchAllKeyValue() and ::iterateKeyValue()](doctrine#4338) thanks to @morozov BC Fix,Query ------------ - [4330: Fix regression in QueryBuilder::and|orWhere()](doctrine#4330) thanks to @BenMorel Test Suite ---------- - [4321: Update PHPUnit to 9.4](doctrine#4321) thanks to @morozov Columns,SQL Server,Schema Managers ---------------------------------- - [4315: Fix handling existing SQL Server column comment when other properties change](doctrine#4315) thanks to @trusek CI -- - [4310: Migrate jobs away from Travis to Github Actions ](doctrine#4310) thanks to @greg0ire BC Fix,Connections ------------------ - [4308: doctrine#4295 Keep master, slaves, keepReplica params in MasterSlaveConnection](doctrine#4308) thanks to @kralos New Feature,Prepared Statements ------------------------------- - [4289: Add a fetch mode methods for "PDO::FETCH&doctrine#95;KEY&doctrine#95;PAIR"](doctrine#4289) thanks to @tswcode Bug,SQL Server,Schema --------------------- - [3400: Wrong column comment setting command in migrations of SQL Server](doctrine#3400) thanks to @msyfurukawa # gpg: Signature made Mon Oct 19 04:18:17 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key

greg0ire force-pushed the travis-to-gh branch 14 times, most recently from dbc940c to fe06461 Compare September 29, 2020 12:29

greg0ire changed the title ~~Migrate some jobs from Travis to Github Actions~~ Migrate jobs away from Travis to Github Actions Sep 29, 2020

greg0ire force-pushed the travis-to-gh branch from 358c2e6 to fe06461 Compare September 29, 2020 12:46

greg0ire requested a review from morozov September 29, 2020 12:46

greg0ire marked this pull request as ready for review September 29, 2020 12:46

bendavies reviewed Sep 29, 2020

View reviewed changes

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved

greg0ire commented Sep 29, 2020

View reviewed changes

greg0ire force-pushed the travis-to-gh branch from fe06461 to 3c007f3 Compare September 29, 2020 16:55

greg0ire force-pushed the travis-to-gh branch from 8ee26df to 471bc57 Compare October 15, 2020 06:20

greg0ire force-pushed the travis-to-gh branch from 471bc57 to 94fa7f2 Compare October 15, 2020 06:34

greg0ire requested a review from morozov October 15, 2020 06:57

greg0ire force-pushed the travis-to-gh branch from 94fa7f2 to a2ed6a8 Compare October 15, 2020 07:07

greg0ire force-pushed the travis-to-gh branch from a2ed6a8 to 649b193 Compare October 15, 2020 07:18

Migrate jobs away from Travis to Github Actions

5bf8e74

It should be faster, and will result in one fewer CI platform to maintain.

greg0ire force-pushed the travis-to-gh branch from 649b193 to 5bf8e74 Compare October 15, 2020 07:25

morozov approved these changes Oct 15, 2020

View reviewed changes

greg0ire merged commit 908cdc6 into doctrine:2.11.x Oct 15, 2020

greg0ire deleted the travis-to-gh branch October 15, 2020 16:20

greg0ire added this to the 2.11.2 milestone Oct 15, 2020

This was referenced Oct 15, 2020

[2.12] PHP 8 compatibility #4347

Merged

Manually merge 2.11.x into 3.0.x #4351

Merged

bendavies reviewed Oct 17, 2020

View reviewed changes

.github/workflows/continuous-integration.yml

Comment on lines +521 to +522

Copy link

Contributor

bendavies Oct 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

mvorisek mentioned this pull request Oct 18, 2020

Run CI on push to any branch and schedule all workflows hourly doctrine/orm#8309

Closed

github-actions bot mentioned this pull request Oct 19, 2020

Merge release 2.11.2 into 2.12.x #4358

Closed

greg0ire mentioned this pull request Jan 5, 2022

Remove trailing comma in a PDO object parameters #5161

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate jobs away from Travis to Github Actions #4310

Migrate jobs away from Travis to Github Actions #4310

greg0ire commented Sep 28, 2020 •

edited

Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020

greg0ire Sep 29, 2020

morozov commented Sep 29, 2020

greg0ire commented Sep 29, 2020

greg0ire commented Sep 29, 2020 •

edited

Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020 •

edited

Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020

greg0ire commented Oct 15, 2020

greg0ire commented Oct 15, 2020 •

edited

Loading

greg0ire commented Oct 15, 2020 •

edited

Loading

greg0ire commented Oct 15, 2020

morozov commented Oct 15, 2020 •

edited

Loading

greg0ire commented Oct 15, 2020

morozov commented Oct 15, 2020 •

edited

Loading

morozov commented Oct 15, 2020

thomasrockhu commented Oct 15, 2020

bendavies Oct 17, 2020

greg0ire Oct 17, 2020

bendavies Oct 17, 2020

bendavies commented Oct 17, 2020

Migrate jobs away from Travis to Github Actions #4310

Migrate jobs away from Travis to Github Actions #4310

Conversation

greg0ire commented Sep 28, 2020 • edited Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020

greg0ire Sep 29, 2020

Choose a reason for hiding this comment

morozov commented Sep 29, 2020

greg0ire commented Sep 29, 2020

greg0ire commented Sep 29, 2020 • edited Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020 • edited Loading

greg0ire commented Sep 29, 2020

bendavies commented Sep 29, 2020

greg0ire commented Oct 15, 2020

greg0ire commented Oct 15, 2020 • edited Loading

greg0ire commented Oct 15, 2020 • edited Loading

greg0ire commented Oct 15, 2020

morozov commented Oct 15, 2020 • edited Loading

greg0ire commented Oct 15, 2020

morozov commented Oct 15, 2020 • edited Loading

morozov commented Oct 15, 2020

thomasrockhu commented Oct 15, 2020

bendavies Oct 17, 2020

Choose a reason for hiding this comment

greg0ire Oct 17, 2020

Choose a reason for hiding this comment

bendavies Oct 17, 2020

Choose a reason for hiding this comment

bendavies commented Oct 17, 2020

greg0ire commented Sep 28, 2020 •

edited

Loading

greg0ire commented Sep 29, 2020 •

edited

Loading

bendavies commented Sep 29, 2020 •

edited

Loading

greg0ire commented Oct 15, 2020 •

edited

Loading

greg0ire commented Oct 15, 2020 •

edited

Loading

morozov commented Oct 15, 2020 •

edited

Loading

morozov commented Oct 15, 2020 •

edited

Loading