Bump Psalm level to 3

[morozov]

Q	A
Type	improvement
BC Break	no

[greg0ire]

Please check Slack, I'd like to talk about merges up.

[greg0ire]

I have recently seen people at Sonata using something even better: MockObject<Connection>. Would that work for us?

[morozov]

This doesn't seem to work with the latest version of dependencies:

$ composer show | grep psalm

psalm/plugin-phpunit                           0.10.1  Psalm plugin for PHPUnit
vimeo/psalm                                    3.17.2  A static analysis tool for finding...

$ psalm

...
ERROR: InvalidArgument - tests/Doctrine/Tests/DBAL/Types/VarDateTimeTest.php:67:71 - Argument 2 of Doctrine\DBAL\Types\VarDateTimeType::convertToPHPValue expects Doctrine\DBAL\Platforms\AbstractPlatform, PHPUnit\Framework\MockObject\MockObject<Doctrine\DBAL\Platforms\AbstractPlatform> provided (see https://psalm.dev/004)
        self::assertSame($date, $this->type->convertToPHPValue($date, $this->platform));


------------------------------
251 errors found
------------------------------

[greg0ire]

Okay, I can't find the piece of code where I see that so nevermind…

[greg0ire]

Let's avoid the negative logic and the else:

Suggested change

	if ($error !== null) {
	$message = $error['message'];
	} else {
	$message = 'Unknown error';
	}
	if ($error === null) {
	return new self('Unknown error');
	}
	return new self($error['message']);

[greg0ire]

Suggested change

	$sql = 'SELECT test_int, test_string'
	. ', ' . $platform->getBitOrComparisonExpression('test_int', 2) . ' AS bit_or'
	. ', ' . $platform->getBitAndComparisonExpression('test_int', 2) . ' AS bit_and'
	. ' FROM fetch_table';
	$sql = sprintf(
	<<<'SQL'
	SELECT
	test_int,
	test_string,
	%s AS bit_or,
	%s as bit_and
	FROM fetch_table
	SQL
	,
	$platform->getBitOrComparisonExpression('test_int', 2),
	$platform->getBitAndComparisonExpression('test_int', 2)
	);

modulo the cs issues of course