Remove warning comment from PDOOracle driver #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is something bad with CI |
|
Hi @beberlei, that comment is from yours commit 5be1613#diff-1c5108ac2719f535f6603abecd44a515c25b065494276cd10913f9a3734c31c1R27 . I know, 9 years ago, but can you provide your feedback on it, is there still any known segfault? |
|
I reported one of the CI issues here: shivammathur/setup-php#325, I'm hoping the otherwise is transient. |
|
@shivammathur patched the issue, let's try again. |
|
Okay it works. The next issue seems to be PHP 8 + pdo_mysql: it fails with both MariaDB and MySQL, only with that driver and that version of PHP. UPD: I think it might be related to php/php-src@5075240 See #4396 for a fix. |
morozov
reviewed
Nov 1, 2020
greg0ire
reviewed
Nov 1, 2020
greg0ire
approved these changes
Nov 1, 2020
morozov
changed the title
|
Thanks, @mvorisek. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am no longer aware of any segfaults, if so, please be specific.
Comment added in - 5be1613 which title links to #1295