Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning comment from PDOOracle driver #4393

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Remove warning comment from PDOOracle driver #4393

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80b055
Remove segfault comment from PDOOracle driver
mvorisek Oct 31, 2020
29fc5c6
Remove no longer valid comment - pdo_oci is maintaned by php people
mvorisek Nov 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/Doctrine/DBAL/Driver/PDOOracle/Driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
/**
* PDO Oracle driver.
*
* WARNING: This driver gives us segfaults in our testsuites on CLOB and other
* stuff. PDO Oracle is not maintained by Oracle or anyone in the PHP community,
* WARNING: PDO Oracle is not maintained by Oracle or anyone in the PHP community,
mvorisek marked this conversation as resolved.
Show resolved Hide resolved
mvorisek marked this conversation as resolved.
Show resolved Hide resolved
* which leads us to the recommendation to use the "oci8" driver to connect
* to Oracle instead.
*
Expand Down