Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset #4614

Merged
merged 1 commit into from
Apr 21, 2021
Merged

[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset #4614

merged 1 commit into from
Apr 21, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 20, 2021

Q A
Type improvement
BC Break no

Closes #4613.

@morozov
Copy link
Member Author

morozov commented Apr 20, 2021

The build passed. I'm going to retarget this against 3.1.x.

@morozov morozov changed the base branch from 4.0.x to 3.1.x April 20, 2021 22:14
@morozov morozov added this to the 3.1.1 milestone Apr 20, 2021
@morozov morozov marked this pull request as ready for review April 21, 2021 05:40
@morozov morozov requested review from beberlei and greg0ire April 21, 2021 05:40
@morozov morozov merged commit 7dc3905 into doctrine:3.1.x Apr 21, 2021
@morozov morozov deleted the issues/4613 branch April 21, 2021 15:41
This was referenced Apr 29, 2021
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
Character Encoding Connections MySQL Test Suite
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary() is failing on CI
2 participants
@morozov @greg0ire