Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Doctrine Cache 2 #4623

Merged
merged 1 commit into from
May 1, 2021
Merged

Support Doctrine Cache 2 #4623

merged 1 commit into from
May 1, 2021

Conversation

derrabus
Copy link
Member

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

This PR proposes to indicate compatibility with Doctrine Cache 2.

@derrabus derrabus mentioned this pull request Apr 29, 2021
Merged
alcaeus
alcaeus requested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctrine/cache dependency needs to be bumped at least for require-dev, but rest LGTM

alcaeus
alcaeus previously approved these changes Apr 29, 2021
View reviewed changes
@alcaeus alcaeus requested review from morozov and greg0ire April 29, 2021 08:38
@morozov
Copy link
Member

morozov commented Apr 29, 2021

To fix the build failure, we need to backport #4614.

greg0ire
greg0ire previously approved these changes Apr 29, 2021
View reviewed changes
morozov
morozov previously approved these changes Apr 29, 2021
View reviewed changes
SenseException
SenseException reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is currently only loading doctrine/cache 1.x on composer install. It would be great if some of them are installing 2.x to show that the tests are also working with 2.x.

@derrabus
Copy link
Member Author

@SenseException I've tested with 2.0-dev locally. If you want v2 to show up in CI, someone would have to tag 2.0.0 on the Doctrine Cache repo or add a job to this repo that tests with "minimum-stability": "dev".

@greg0ire
Copy link
Member

Let's wait for 2.0.0 to happen then?

@alcaeus
Copy link
Member

alcaeus commented Apr 30, 2021 •
edited
Loading

Done: https://github.com/doctrine/cache/releases/tag/2.0.0

@greg0ire greg0ire closed this Apr 30, 2021
@greg0ire greg0ire reopened this Apr 30, 2021
@derrabus derrabus dismissed stale reviews from morozov and greg0ire via bc57508 April 30, 2021 11:11
@derrabus
Copy link
Member Author

I've added small fixes to make Psalm happy, now that Doctrine Cache 2 has been tagged.

greg0ire
greg0ire previously approved these changes Apr 30, 2021
View reviewed changes
SenseException
SenseException previously approved these changes Apr 30, 2021
View reviewed changes
@derrabus derrabus dismissed stale reviews from SenseException and greg0ire via b7aedb4 May 1, 2021 13:48
@derrabus derrabus force-pushed the doctrine-cache-2 branch from bc57508 to b7aedb4 Compare May 1, 2021 13:48
morozov
morozov previously approved these changes May 1, 2021
View reviewed changes
@derrabus derrabus force-pushed the doctrine-cache-2 branch from b7aedb4 to cf25812 Compare May 1, 2021 16:01
@greg0ire greg0ire merged commit 35a4071 into doctrine:2.13.x May 1, 2021
@greg0ire
Copy link
Member

greg0ire commented May 1, 2021

Thanks @derrabus !

@greg0ire greg0ire added this to the 2.13.2 milestone May 1, 2021
@derrabus derrabus deleted the doctrine-cache-2 branch May 1, 2021 17:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@alcaeus alcaeus alcaeus left review comments

@greg0ire greg0ire greg0ire left review comments

@SenseException SenseException SenseException left review comments

Assignees
No one assigned
Labels
Cache Improvement
Projects
None yet
Milestone
2.13.2
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @morozov @greg0ire @alcaeus @SenseException