Deprecate redundant AbstractPlatform methods #4724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily deprecates the
AbstractPlatform
methods that produce the SQL fragments that don't vary across supported platforms (e.g.getCountExpression()
→COUNT()
). The additional reasons to deprecate them are:IS NULL
is used as SQL everywhere instead of usinggetIsNullExpression()
.SIN()
,COS()
andACOS()
but there's noASIN()
,TAN()
and so on. Implementing a full set of trigonometric functions in a DBAL would be weird.It also deprecates a bunch of
supports*()
methods that describe the features consistently implemented across all the supported platforms (i.e. always return the same value).Additionally, it documents some more deprecations of the code that is already removed in 4.0.x:
The methods that support the GUID type. The type was deprecated earlier in DBAL 2.8 (see Deprecated usage of DB-generated UUIDs #3212)reverted in Revert GUID type deprecation #4726.