Fix hardcoded varchar default length

[mvorisek]

Q	A
Type	improvement
BC Break	no - the hardcoded value is default on all platforms
Fixed issues	n/a

Summary

When AbstractPlatform::getVarcharDefaultLength is overriden, it must be honored AbstractPlatform::getCreateTableSQL.

[morozov]

This change doesn't belong to a patch release since it doesn't address any consumer-facing issues. At the same time, this method is deprecated in 3.2.x (#4724) and will trigger a deprecation notice.

[mvorisek]

This change doesn't belong to a patch release since it doesn't address any consumer-facing issues. At the same time, this method is deprecated in 3.2.x (#4724) and will trigger a deprecation notice.

rebased onto 3.2.x

I use to override getVarcharDefaultLength in my code to support 255 characters by default on some platforms (instead of 255 bytes). What is the replacement to set a default VARCHAR length newly?

[morozov]

rebased onto 3.2.x

You'll have to change trigger() to triggerIfCalledFromOutside() in:

dbal/src/Platforms/AbstractPlatform.php

Lines 587 to 589 in 0edd213

	public function getVarcharDefaultLength()
	{
	Deprecation::trigger(

What is the replacement to set a default VARCHAR length newly?

There's no replacement for that. The column length will have to be specified explicitly for those platforms that require it (all except for SQLite and PostgreSQL). See #3263.