Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-4 for Doctrine DBAL #621

Closed
wants to merge 1 commit into from
Closed

Use PSR-4 for Doctrine DBAL #621

wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 20, 2014

symfony/symfony#11189 for Doctrine DBAL

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-926

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

There is no advantage in porting a PSR-0 compliant library to PSR-4. Please don't change it unless there's an advantage in doing so.

@Ocramius Ocramius closed this Jun 20, 2014
@Ocramius Ocramius self-assigned this Jun 20, 2014
@Tobion
Copy link
Contributor Author

Tobion commented Jun 20, 2014

Advantage is it's faster

@Tobion
Copy link
Contributor Author

Tobion commented Jun 20, 2014

I would rather ask what's the disadvantage of using PSR-4 in composer?

@Ocramius
Copy link
Member

@Tobion it's not faster. For production purposes, you are supposed to use composer dump-autoload --optimize. Note that doctrine project also voted against PSR-4 in FIG.

@Tobion
Copy link
Contributor Author

Tobion commented Jun 20, 2014

Why would it not be faster in development? It's just as important. It removes the logic to load PEAR-like classes in this repo. So it's definitely faster. Again, what's the disadvantage? I don't see it.

@Ocramius
Copy link
Member

That's not I/O - the performance impact is negligible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants