Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PSR-4 in components? #11189

Closed
Tobion opened this issue Jun 20, 2014 · 9 comments
Closed

Use PSR-4 in components? #11189

Tobion opened this issue Jun 20, 2014 · 9 comments

Comments

@Tobion
Copy link
Contributor

Tobion commented Jun 20, 2014

composer.json target-dir is deprecated. Can we switch to PSR-4 in components?
@fabpot
Copy link
Member

fabpot commented Jun 20, 2014

👍

@nicolas-grekas
Copy link
Member

I suggest we benchmark the impact of switching to PSR-4 beforehand.

@stof
Copy link
Member

stof commented Jun 20, 2014

@nicolas-grekas the PSR-4 rules are applied before the PSR-0 ones in the composer autoloader, so this should even improve things a bit.
And the resolution rules are a bit simpler for PSr-4 (no handling of underscores needed)

@Taluu
Copy link
Contributor

Taluu commented Jun 20, 2014

👍

3 similar comments
@apfelbox
Copy link
Contributor

👍

@cordoval
Copy link
Contributor

👍

@sstok
Copy link
Contributor

sstok commented Jun 20, 2014

👍

@Tobion
Copy link
Contributor Author

Tobion commented Jun 20, 2014

Working on it

This was referenced Jun 20, 2014
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Merged
@Seldaek Seldaek mentioned this issue Jun 22, 2014
Closed
@Tobion
Copy link
Contributor Author

Tobion commented Jun 27, 2014

3 merges are missing to be complete for symfony

@Seldaek Seldaek mentioned this issue Nov 12, 2014
Closed
@Tobion Tobion mentioned this issue Apr 11, 2015
Merged
Tobion added a commit that referenced this issue Apr 11, 2015
@Tobion
minor #14323 Use PSR-4 everywhere instead of PSR-0 (Tobion, Seldaek)
e00f037 
This PR was merged into the 2.7 branch.

Discussion
----------

Use PSR-4 everywhere instead of PSR-0

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11189
| License       | MIT

Rebased and updated #12466

Commits
-------

8072213 adjust phpdoc for class not found handler
e2bbf07 add phpunit bridge to psr4
60d4994 Tweak classmap paths
cc17234 Add two more components to psr-4
17f61af Add psr-4 support to the ClassNotFoundFatalErrorHandler
4e85901 Use PSR-4 everywhere instead of PSR-0
@Tobion Tobion closed this as completed Apr 11, 2015
@doctrinebot doctrinebot mentioned this issue Dec 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@fabpot @Taluu @nicolas-grekas @cordoval @stof @Tobion @sstok @apfelbox