Add support for configurable migration column length. #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SlvrEagle23 Can you add a test ? Thanks for the PR |
lcobucci
suggested changes
Aug 18, 2017
| * | ||
| * @param int $columnLength The migration string column length. | ||
| */ | ||
| public function setMigrationsColumnLength($columnLength) |
There was a problem hiding this comment.
The codebase I'm PR'ing against doesn't have type declarations, so I was trying to stay consistent with that.
There was a problem hiding this comment.
The codebase has already been changed to require PHP 7.1 😉
| * | ||
| * @return int $migrationsColumnLength The migration string column length. | ||
| */ | ||
| public function getMigrationsColumnLength() |
|
@SlvrEagle23 do you want to try updating this for 2.0? Do you mind if I update it and merge? |
|
@jwage If you want to take it on, by all means I don't mind. I don't have the same dev environment set up as I did when I submitted it, and I updated much of my own code to use MariaDB 10.2, which allows the longer fields. |
jwage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Because the Migrations Configuration object's
createMigrationTable()function references private properties, it is difficult if not impossible to override on a per-project basis if necessary to specify a user-configurable string length. Adding another private property seems like the most low-friction way of resolving the issue.