Fix composer.json platform.php setting.

[jwage]

Q	A
Type	improvement
BC Break	no
Fixed issues	#701

Summary

This was something that @theofidry suggested we add to composer.json for the box build process. I admit I don't fully understand why. Maybe someone can chime in here on why it is needed and what the value should be.

[theofidry]

I'll try to give a clear explanation :)

If you are on PHP 7.2+ and run a composer update, because your composer.json constraint is ^7.1, it might install code that is compatible only with PHP 7.2+. If that's the case, when you will build the PHAR, you will ship a PHAR working only for PHP 7.2+ instead of ^7.1.

Putting this configuration enforce Composer to behave as if you were running on a specific version of PHP, so here 7.1.0, regardless of your actual PHP version on your machine.

Note that this config should be unset for the build not building the PHAR with for example with composer config --unset platform.php

[Majkl578]

I'd argue you should explicitly set the platform before the packaging, not making it by default present in composer.json.
This in the end affects testing of lowest/latest dependencies too and will always i.e. reject Symfony 4 completely on CI.

[theofidry]

This in the end affects testing of lowest/latest dependencies too and will always i.e. reject Symfony 4 completely on CI.

Not if you remove it:

Note that this config should be unset for the build not building the PHAR with for example with composer config --unset platform.php

If you don't set it by default you must not forget to add it when building the PHAR locally, so maybe it can be added to the build script instead.

[Majkl578]

Ok, then anyone who clones the repo will... Telling everyone to unset the platform just to accomodate a release process is a bit overkill imho.

If you don't set it by default you must not forget to add it when building the PHAR locally

Can be done by the build-phar.sh script.

[Majkl578]

See alternative apporach in #705.

[jwage]

@Majkl578 I like that approach better 👍 closing this PR.