Set lowest allowed PHP before generating PHAR #705
Conversation
| @@ -2,4 +2,10 @@ | |||
|
|
|||
| ./download-box.sh | |||
|
|
|||
| # lock PHP to minimum allowed version | |||
| composer config platform.php 7.1.0 | |||
| composer update | |||
There was a problem hiding this comment.
Maybe use --no-dev here? cc @theofidry
There was a problem hiding this comment.
it is my understanding that box already does --no-dev automatically when building the phar.
There was a problem hiding this comment.
To be more exact it simply discards the dev dependency directly done by reading composer.lock, it doesn't do a update or install behind the scenes. So there might still some minor optimization gains by doing install --no-dev, but for a compressed PHAR I don't think the extra faff is worth it
There was a problem hiding this comment.
Cool. I guess --no-dev -oa (optimized authoritative autoloader) may have some real (little) impact. :)
There was a problem hiding this comment.
The autoloader is dumped with classmap authoritative by default so the real optimisation you can squeeze from install --no-dev is by removing a few more test files eventually (I'm actually not sure you would get a diff at all)
Summary
Alternative to #704.