spl_object_hash() vs spl_object_id()

[franmomu]

BC Break Report

Q	A
BC Break	yes
Version	2.10

Summary

After #8837, there are some UoW methods that the parameter has changed:

orm/lib/Doctrine/ORM/UnitOfWork.php

Lines 3243 to 3254 in 81d472f

	/**
	* INTERNAL:
	* Clears the property changeset of the entity with the given OID.
	*
	* @param int $oid The entity's OID.
	*
	* @return void
	*/
	public function clearEntityChangeSet($oid)
	{
	unset($this->entityChangeSets[$oid]);
	}

orm/lib/Doctrine/ORM/UnitOfWork.php

Lines 3025 to 3040 in 81d472f

	/**
	* INTERNAL:
	* Sets a property value of the original data array of an entity.
	*
	* @param int $oid
	* @param string $property
	* @param mixed $value
	*
	* @return void
	*
	* @ignore
	*/
	public function setOriginalEntityProperty($oid, $property, $value)
	{
	$this->originalEntityData[$oid][$property] = $value;
	}

Because the OID is different, at first I thought they were internal, but apparently it is some kind of internal notes.

Previous behavior

Before this, for calling these method you should generate the oid with spl_object_hash()

Current behavior

Now that oid is not valid anymore.

How to reproduce

Tests started to fail in https://github.com/doctrine-extensions/DoctrineExtensions

[greg0ire]

Hi! Can you please link to the failing tests?

[franmomu]

Sure!

• Failing: https://github.com/franmomu/DoctrineExtensions/runs/3968379322?check_suite_focus=true
• Here the spl_object_hash calls were changed to spl_object_id: https://github.com/franmomu/DoctrineExtensions/runs/3968449631?check_suite_focus=true (there are still some other failing test that I'll try to figure it out why, update: I guess it's because the failing ones are from ODM and there UoW uses spl_object_hash)

UPDATE 2: with an ugly fix to call spl_object_hash() for ODM and spl_object_id() for ORM tests pass: franmomu/DoctrineExtensions#9

[greg0ire]

Great job! Since you are not stuck, I think it's fine not to revert this, and to document the minor BC-break.