Document BC break #9143
Merged
Document BC break #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
approved these changes
Oct 22, 2021
derrabus
approved these changes
Oct 30, 2021
|
@greg0ire a way to provide a BC layer would be to detect cases passing a string as argument instead of an int, and converting the object hash to an object id (and triggering a deprecation of course). the logic for that is available in the implementation of the |
|
Good to know! I'll reuse it if anyone else complains about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9141
I'm not great at assessing the severity of BC-breaks, so please do tell if you feel we should revert #8837 , or if you have an idea to somehow make both things work without affecting performance too much.
cc @franmomu