Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducer for "typed property must not be accessed before initialization..." bug #10337

Closed
wants to merge 3 commits into from

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Dec 22, 2022

This is a reproducer for #10336.

The test passes on 2.13.x

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 2, 2023

Can you please add back the lines mentioned in #10336 (comment) to see the effect on tests?

@kbond kbond force-pushed the uninitialized-prop-reproducer branch from 0541d0c to a2bcb31 Compare January 2, 2023 21:16
@kbond
Copy link
Contributor Author

kbond commented Jan 2, 2023

Re-adding the lines fixed this specific test but breaks MappedSuperclassTest.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 2, 2023

Great thanks. And the break appears only with the new proxies. Looks like they brought some behavior change that we need to understand.

@simonberger
Copy link
Contributor

There is another problem in the ProxyFactory::generateSkippedProperties ignoring private properties of parent classes which the id property of the test classes is. I can implement a solution or at least prototype later today.

@nicolas-grekas
Copy link
Member

Fixed in #10385. This PR can be closed. Thanks for the reproducer!

@kbond
Copy link
Contributor Author

kbond commented Jan 9, 2023

Great! Thanks @nicolas-grekas!

@kbond kbond closed this Jan 9, 2023
@kbond kbond deleted the uninitialized-prop-reproducer branch January 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants