Fix initializing lazy objects and get rid of "Typed property must not be accessed before initialization" errors #10385
Conversation
… be accessed before initialization" errors
nicolas-grekas
force-pushed
the
uninitialized-prop-reproducer
branch
from
b91484a to
a56c278
Compare
nicolas-grekas
force-pushed
the
uninitialized-prop-reproducer
branch
from
a56c278 to
3b8692f
Compare
|
Where is the point in taking my fix and implement it in just a different coding style? |
|
No specific point, I just missed your PR sorry, thanks for point at it. |
|
@simonberger closed #10362, so let's get this one merged :-) |
|
LGTM, fixes my similar issue. thanks NG. |
| if (isset($this->_hints[Query::HINT_REFRESH_ENTITY])) { | ||
| $this->registerManaged($this->class, $this->_hints[Query::HINT_REFRESH_ENTITY], $data); | ||
| } | ||
|
|
There was a problem hiding this comment.
These lines were removed in #10187 as pointed out in #10336 (comment)
|
|
||
| $skippedProperties[$prefix . $name] = true; | ||
| $filter = ReflectionProperty::IS_PRIVATE; | ||
| $reflector = $reflector->getParentClass(); |
There was a problem hiding this comment.
This seems to do the same as before, but for does it also for ancestors in the class hierarchy, retrieving only private properties for those (I guess public and protected are already retrieved at the first iteration because they are inherited).
| $this->_em->clear(); | ||
|
|
||
| $this->assertSame('foo', $entity->relation->value); | ||
| } |
There was a problem hiding this comment.
Although this test 100% covers this change, the while loop only ever does one iteration. Yet when I use git restore --source=origin/2.14.x lib/Doctrine/ORM/Proxy/ProxyFactory.php, a preexisting test fails Doctrine\Tests\ORM\Functional\MappedSuperclassTest::testCRUD, which means the scenario where there is more than 1 iteration is already covered 👍
It gets broken by the changes in SimpleObjectHydrator, and fixed by the changes in ProxyFactory
greg0ire
requested review from
derrabus,
ostrolucky and
SenseException
and removed request for
ostrolucky
Fix #10336