Include parameter types in hydration cache key generation #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
derrabus
force-pushed
the
bugfix/types-in-cache-key
branch
from
c524c0d to
f5169b8
Compare
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 31, 2022
* 2.14.x: Shorter deprecation message (doctrine#10357) Add Fully-Qualified class name in UnrecognizedField exception to ease debugging (doctrine#10342) Include parameter types in hydration cache key generation (doctrine#10355)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 31, 2022
* 2.15.x: Shorter deprecation message (doctrine#10357) Add Fully-Qualified class name in UnrecognizedField exception to ease debugging (doctrine#10342) Include parameter types in hydration cache key generation (doctrine#10355) Allow doctrine/instantiator 2 (doctrine#10351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10354 (comment)
We were calling this DBAL method wrong and passed the connection hints as parameter types. I'm not sure if this has really caused issues, but let's call the method as it's meant to be called.