Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter deprecation message #10357

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Dec 31, 2022

Sorry for the follow-up to #10342. 😓

Everything we deprecate is supposed to be removed in 3.0, so let's keep this kind of message brief.

cc @Kern046

@derrabus derrabus added this to the 2.14.1 milestone Dec 31, 2022
@derrabus derrabus merged commit 85ac276 into doctrine:2.14.x Dec 31, 2022
@derrabus derrabus deleted the chore/shorter-deprecation branch December 31, 2022 16:43
derrabus added a commit to derrabus/orm that referenced this pull request Dec 31, 2022
* 2.14.x:
  Shorter deprecation message (doctrine#10357)
  Add Fully-Qualified class name in UnrecognizedField exception to ease debugging (doctrine#10342)
  Include parameter types in hydration cache key generation (doctrine#10355)
@Kern046
Copy link
Contributor

Kern046 commented Dec 31, 2022

@derrabus I used the same pattern from UPGRADE.md::l.63 if you also want to update this message :)

@derrabus
Copy link
Member Author

Yeah, maybe we should do revise the upgrade log before we release 3.0. 😅

derrabus added a commit to derrabus/orm that referenced this pull request Dec 31, 2022
* 2.15.x:
  Shorter deprecation message (doctrine#10357)
  Add Fully-Qualified class name in UnrecognizedField exception to ease debugging (doctrine#10342)
  Include parameter types in hydration cache key generation (doctrine#10355)
  Allow doctrine/instantiator 2 (doctrine#10351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants