Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sever ties to common #10998

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Sever ties to common #10998

merged 1 commit into from
Oct 15, 2023

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 11, 2023 •
edited
Loading

Companion PR: #10999

@greg0ire greg0ire mentioned this pull request Oct 11, 2023
Merged
SenseException
SenseException previously approved these changes Oct 11, 2023
View reviewed changes
@greg0ire greg0ire marked this pull request as draft October 12, 2023 20:06
@greg0ire greg0ire force-pushed the sever-ties-to-common branch from 8bebaef to 7ca6e55 Compare October 13, 2023 07:05
stof
stof reviewed Oct 13, 2023
View reviewed changes
lib/Doctrine/ORM/Cache/Persister/Entity/AbstractEntityPersister.php Outdated Show resolved Hide resolved
lib/Doctrine/ORM/Configuration.php Outdated Show resolved Hide resolved
lib/Doctrine/ORM/Proxy/DefaultProxyClassNameResolver.php Outdated Show resolved Hide resolved
lib/Doctrine/ORM/Cache/DefaultCache.php Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@greg0ire greg0ire mentioned this pull request Oct 13, 2023
Merged
@beberlei
Copy link
Member

I don't know if this must be configurable to end users, I prefer to hardcode the logic like it was before with ClassUtils::getClass.

@greg0ire
Copy link
Member Author

@beberlei I didn't provide a setter in the Configuration object, so it is not really configurable. I'm using Configuration as a convenient way to get that service everywhere I need it, without resorting to the singleton pattern, but maybe there is a better way?

@greg0ire greg0ire force-pushed the sever-ties-to-common branch from 7ca6e55 to a095f6c Compare October 14, 2023 21:32
@greg0ire greg0ire marked this pull request as ready for review October 14, 2023 21:40
@greg0ire
Remove dependency on doctrine/common
b1d7fcf 
We were only relying on it for functionality related to proxies, which
is very little code.
@greg0ire greg0ire force-pushed the sever-ties-to-common branch from a095f6c to b1d7fcf Compare October 15, 2023 09:55
@derrabus derrabus added this to the 3.0.0 milestone Oct 15, 2023
@derrabus derrabus merged commit 4444065 into doctrine:3.0.x Oct 15, 2023
56 checks passed
@greg0ire greg0ire deleted the sever-ties-to-common branch October 15, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@derrabus derrabus derrabus approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@greg0ire @beberlei @stof @SenseException @derrabus