Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start moving travis phpunit runs to Github actions. #8317

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

beberlei
Copy link
Member

Move from Travis CI to Github for PHPUnit tests.

@beberlei beberlei closed this Oct 25, 2020
@beberlei beberlei reopened this Oct 25, 2020
@beberlei beberlei marked this pull request as ready for review October 27, 2020 00:28
@beberlei beberlei requested a review from greg0ire October 27, 2020 00:28
@beberlei beberlei mentioned this pull request Oct 27, 2020
4 tasks
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we no longer use composer install… should composer.lock be removed from version control?

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@beberlei
Copy link
Member Author

@greg0ire its a good question about composer install/update, this probably goes hand in hand with pin tooling versions to specific versions to avoid failures suddenly starting due to new versions of psalm, phpunit, phpstan, phpcs...

@greg0ire
Copy link
Member

@beberlei see https://github.com/orgs/doctrine/teams/doctrinecore/discussions/21 if you want to dive into that rabbit hole :)

@greg0ire

This comment has been minimized.

@beberlei beberlei changed the base branch from 2.8.x to 2.7 November 7, 2020 12:59
This removes all artifacts used for TravisCI testing and replaces them
with the existing infrastructure for Github Actions from DBAL component.

In addition some test changes were needed and triggered larger Coding
Style cleanups in 3 test files.
@greg0ire
Copy link
Member

greg0ire commented Nov 7, 2020

Guess I will have to upgrade to PHPUnit 8 😅

UPD: upgrading to PHPUnit 8 seems impossible because of a conflict between the API of TestCase and VerifyDeprecation

protected function expectDeprecationMessage(string $message) : void

I will try using XDebug instead, let's hope it will not slow down the build too much 🤞

UPD: actually I can just rename the VerifyDeprecations API, it's not public.

@greg0ire greg0ire force-pushed the GithubActions branch 2 times, most recently from 917544c to ecdbf81 Compare November 7, 2020 16:09
@greg0ire
Copy link
Member

greg0ire commented Nov 7, 2020

It's going to be too big, let's merge your PR as is, I'll do the PHPUnit 8 migration and coverage upload in a separate PR.

- "7.3"
- "7.4"
deps:
- "fixed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use "normal" here? You are using composer update, so the dependencies are not fixed.

@greg0ire
Copy link
Member

greg0ire commented Nov 7, 2020

Let's remove composer.lock from version control? As concluded with https://github.com/orgs/doctrine/teams/doctrinecore/discussions/21

@beberlei beberlei merged commit c270eba into doctrine:2.7 Nov 7, 2020
@beberlei beberlei deleted the GithubActions branch November 7, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants