Make Reflection available to ConvertMappingCommand #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
reviewed
Mar 31, 2022
|
Okay, could this be a fix? |
|
Can you please open an issue that describes and reproduces your problem first? I'm having a hard time understanding this change. |
|
I have opened an issue with how to reproduce the bug #9659 |
|
The AnnotationDriver has the same kind of code to allow mapping conversion. Its an unfortunate side effect of our abstraction being sub optimal |
|
@bartholdbos yes this is the fix, can you duplicate it into AttributeDrivwr? |
|
Yes I have duplicated the fix into AttributeDriver |
bartholdbos
force-pushed
the
no-reflection-class-in-attribute-convert-mapping-command
branch
from
d946ed4 to
21dfe6a
Compare
This fixes an exception when exporting mapping information using the ConvertMappingCommand from Attributes. The AttributeDriver needs a ReflectionClass in the loadMetadataForClass method. The ConvertMappingCommand sets up the ClassMetadataFactory as an instance of DisconnectedClassMetadataFactory which does not return ReflectionClasses
This reverts commit 35cc30b.
bartholdbos
force-pushed
the
no-reflection-class-in-attribute-convert-mapping-command
branch
from
21dfe6a to
b2bebd2
Compare
|
I added the PHPStan warning to the baseline as was done for the AnnotationDriver |
|
The pipeline is green, I think it's ready to be reviewed (and merged hopefully) |
|
@beberlei Hi Benjamin, could you maybe review the fix please? |
derrabus
approved these changes
Jun 13, 2022
|
Thank you @bartholdbos! |
bartholdbos
deleted the
no-reflection-class-in-attribute-convert-mapping-command
branch
bartholdbos
restored the
no-reflection-class-in-attribute-convert-mapping-command
branch
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jun 17, 2022
* 2.13.x: Deprecate omitting the alias in QueryBuilder (doctrine#9765) Run tests on PHP 8.2 (doctrine#9840) PHPStan 1.7.13 (doctrine#9844) Flip conditional extension of legacy AnnotationDriver class (doctrine#9843) PHP CodeSniffer 3.7 (doctrine#9842) Make Reflection available to ConvertMappingCommand (doctrine#9619) Add missing property declaration Use proper API for introspection of tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9659
This fixes an exception when exporting mapping information using the
ConvertMappingCommand from Attributes. The AttributeDriver needs a
ReflectionClass in the loadMetadataForClass method. The
ConvertMappingCommand sets up the ClassMetadataFactory as an instance of
DisconnectedClassMetadataFactory which does not return ReflectionClasses