Run tests on PHP 8.2 #9840
Run tests on PHP 8.2 #9840
Conversation
derrabus
force-pushed
the
ci/php-8.2
branch
2 times, most recently
from
3e2ece0 to
ff0748f
Compare
| @@ -31,6 +31,8 @@ jobs: | |||
| dbal-version: "2.13" | |||
| - php-version: "8.1" | |||
| dbal-version: "3@dev" | |||
| - php-version: "8.2" | |||
| dbal-version: "3@dev" | |||
There was a problem hiding this comment.
As long as doctrine/dbal#5381 is not released, the tests will fail on PHP 8.2 if we don't test against a dev snapshot.
| @@ -52,6 +54,8 @@ jobs: | |||
|
|
|||
| - name: "Install dependencies with Composer" | |||
| uses: "ramsey/composer-install@v1" | |||
| with: | |||
| composer-options: "--ignore-platform-req=php+" | |||
There was a problem hiding this comment.
We need to ignore the upper boundary of PHP version constraints. Otherwise, we cannot install Prophecy (as a dependency of PHPUnit) on PHP 8.2.
There was a problem hiding this comment.
Didn't know about that + syntax 💡
|
The test failures on Postgres are most likely unrelated to PHP 8.2. |
tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php
Outdated
Show resolved
Hide resolved
I pushed the cherry-picked commit to your branch since it's the easiest way to test. |
|
I have reverted all changes to production code. I think it's better to deliver those with 2.13.x. The CI is green now. Shall we merge? |
* 2.13.x: Deprecate omitting the alias in QueryBuilder (doctrine#9765) Run tests on PHP 8.2 (doctrine#9840) PHPStan 1.7.13 (doctrine#9844) Flip conditional extension of legacy AnnotationDriver class (doctrine#9843) PHP CodeSniffer 3.7 (doctrine#9842) Make Reflection available to ConvertMappingCommand (doctrine#9619) Add missing property declaration Use proper API for introspection of tables
PHP 8.2.0-alpha1 has been released and I think we should start monitoring our compatibility with the next PHP version.