Document ORM drivers only really load ORM metadata #9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
assert-drivers-are-orm-specific
branch
5 times, most recently
from
d862703 to
ebfa2f5
Compare
greg0ire
changed the title
greg0ire
changed the title
greg0ire
force-pushed
the
assert-drivers-are-orm-specific
branch
from
ebfa2f5 to
c23b598
Compare
derrabus
reviewed
Apr 24, 2022
greg0ire
commented
Apr 24, 2022
| @@ -31,7 +31,7 @@ protected function convertToClassMetadata(array $entityTables, array $manyTables | |||
|
|
|||
| $metadatas = []; | |||
| foreach ($driver->getAllClassNames() as $className) { | |||
| $class = new ClassMetadataInfo($className); | |||
| $class = new ClassMetadata($className); | |||
There was a problem hiding this comment.
I first implemented this with assert, then was forced to changed this test, which made me think this was a bit risky, hence the change towards phpdoc. It's better anyway, since it makes static analysis able to detect calls to these methods made with ClassMetadataInfo rather than ClassMetadata.
greg0ire
force-pushed
the
assert-drivers-are-orm-specific
branch
from
c23b598 to
85238d4
Compare
derrabus
approved these changes
Apr 24, 2022
You're only removing |
Sorry, when I wrote this I had added some calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I'm not sure I made a great choice in doctrine/persistence#180 when I used templating in
MappingDriverto bind$classNameto$metadata, as double templating does not seem possible, meaning we can't use it to get rid of the docblocks I added:Although this is clearly not a bugfix and touches
src, I'm targeting 2.12.x becauseassertis not supposed to affect production, and touching baseline files is best done on the lowest-supported branch IMO, so that there are not too many conflicts.