Phpstan lvl 7 #180
Merged
Phpstan lvl 7 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is only one directory for which this will work.
We have found that there were lots of conflicts during the last merge up to 3.0. Reaching level 7 on lower branches reduces differences between them and thus the amount of conflits for future merges. It should also ensure that no new PHPStan error are discovered when merging up because they are detected at level 7 and not at level 5.
|
Let's wait for https://www.githubstatus.com/incidents/zbpwygxwb3gw to be resolved before merging this. |
alcaeus
approved these changes
May 16, 2021
| @@ -0,0 +1,11 @@ | |||
| # Circular dependency | |||
|
|
|||
| This package has a development dependency on `doctrine/common`, which has a | |||
There was a problem hiding this comment.
Thanks for documenting this. Is there anything we can do to fix this? Should we prepare doctrine/common to work with persistence 3?
There was a problem hiding this comment.
We could use ^2.0 || ^3.0, but IMO that's a bit "risky" if we do not test that 2.0 actually work with 3, and the benefit is small: that would only fix one weird thing out of the 2 we have to do, namely:
- using
COMPOSER_ROOT_VERSION - using
2.0as a value for it when developing on 3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.