Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few URLs point to the MDN homepage #5

Open
pdehaan opened this issue Dec 4, 2017 · 1 comment
Open

A few URLs point to the MDN homepage #5

pdehaan opened this issue Dec 4, 2017 · 1 comment

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Dec 4, 2017

Steps to reproduce:

$ git grep ': "https://developer.mozilla.org/en-US/",'

Actual results:

globals-docs.json:    "focus": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "name": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "open": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "opera": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFEMergeNodeElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFEMorphologyElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFEOffsetElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFESpotLightElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFETileElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGFETurbulenceElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "SVGGlyphRefElement": "https://developer.mozilla.org/en-US/",
globals-docs.json:    "XPathException": "https://developer.mozilla.org/en-US/",
@SupremeTechnopriest
Copy link
Contributor

SupremeTechnopriest commented Dec 5, 2017 •
edited
Loading

I just submitted a pull request #7 that will resolve this issue as well. Once merged in, if you land at the mozilla homepage it will be because there are no docs for the specified type yet or this library needs to be rebuilt.

@SupremeTechnopriest SupremeTechnopriest mentioned this issue Dec 5, 2017
Merged
tmcw pushed a commit that referenced this issue Dec 5, 2017
@SupremeTechnopriest @tmcw
feat: Basic WebRTC types, improved build scripts
84f7df0 
* added a gitignore to ignore node modules

* clean up build process

This build directory made no sense to me. It was requiring a non
existent file and writing to an un-used/ un-exported file.  Also the
source file was not exported or used anywhere that I could see. To make
building better I made the following changes:

- rename the `build` directory to `scripts` as `build` is misleading
- remove the file `source.json`
- propagate the last pull request #4 to the build script
- add an npm command to build `npm run build`

Now running `npm run build` will use the file `globals-docs.json` as its
input and output file.  To add more browser features just set a key to
the feature name and the value to https://developer.mozilla.org and run
`npm run build` to resolve the mozilla documentation and generate a new
`globals-docs.json`

* add support for the basic webrtc types

* refactor build script to resolve issue #5

* remove wildcard .log ignore

* remove `SVGColor` global as no browser supports it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdehaan @SupremeTechnopriest