Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /en-US/ from Mozilla docs #4

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Dec 4, 2017

Looks noisy, but the only change is a search-n-replace of "/en-US/" to "/" (effectively removing the URL from the locale and letting developer.mozilla.org serve the more appropriate locale to the user).

Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Excellent, thanks!

@tmcw tmcw merged commit 95ce765 into documentationjs:master Dec 4, 2017
@pdehaan
Copy link
Contributor Author

pdehaan commented Dec 4, 2017

🍻

tmcw pushed a commit that referenced this pull request Dec 5, 2017
* added a gitignore to ignore node modules

* clean up build process

This build directory made no sense to me. It was requiring a non
existent file and writing to an un-used/ un-exported file.  Also the
source file was not exported or used anywhere that I could see. To make
building better I made the following changes:

- rename the `build` directory to `scripts` as `build` is misleading
- remove the file `source.json`
- propagate the last pull request #4 to the build script
- add an npm command to build `npm run build`

Now running `npm run build` will use the file `globals-docs.json` as its
input and output file.  To add more browser features just set a key to
the feature name and the value to https://developer.mozilla.org and run
`npm run build` to resolve the mozilla documentation and generate a new
`globals-docs.json`

* add support for the basic webrtc types

* refactor build script to resolve issue #5

* remove wildcard .log ignore

* remove `SVGColor` global as no browser supports it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants