Fix relative time indication for submission history #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
commented
Mar 21, 2023
| t 'time.yesterday' | ||
| else | ||
| # need to use I18n.t here because the minitest helper dos not support kwargs yet for t | ||
| I18n.t 'time.ago', time: time_ago_in_words(time) |
There was a problem hiding this comment.
Made a pr on minitest-utils to fix the need for this: fnando/minitest-utils#15
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
bmesuere
approved these changes
Mar 21, 2023
niknetniko
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the relative time indication shown on the submission detail page.
The goal of this more custom version of time_ago_in_words was to avoid to many different groupings for recent submissions.
But I grouped to many times under today. Introducing yesterday fixes this.
Closes #4490