Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create state abstraction boundaries for write-ops in the state transition #226

Merged

Conversation

DarianShawn
Copy link
Collaborator

Description

State Transition Function should not call Commit from the Snapshot interface and should only return the entries in the state that have been updated. Then, as part of another workflow, these entries would be updated in the merkle trie.

The PR is merging from Polygon Edge PR 753

Changes include

  • New feature (non-breaking change that adds functionality)

Testing

  • I have tested this code with the official test suite

@DarianShawn DarianShawn added the feature New update to Dogechain label Oct 25, 2022
@DarianShawn DarianShawn self-assigned this Oct 25, 2022
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abrahamcruise321 abrahamcruise321 merged commit 1960bf6 into hardfork/pos Oct 25, 2022
@abrahamcruise321 abrahamcruise321 deleted the feat-seperate-state-abstraction-boundaries branch October 25, 2022 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants