[util] Add DXVK_CONFIG to define additional options #3581
Conversation
* `#` used as separator * options will override/extend those in dxvk.conf file * `DXVK_CONFIG="dxvk.hud=full#dxvk.blah = blah;blah:blah,#"`
src/util/config/config.cpp
Outdated
| // help when debugging configuration issues | ||
| Logger::info(str::format("Found config env: ", confLine)); | ||
|
|
||
| for(auto l : str::split(confLine, "#")) |
There was a problem hiding this comment.
why '#' specifically? that's such an odd choice when everything else either uses ; or :, and much like ; it hard-requires using quotes on the string as well so i don't really see the benefit here.
There was a problem hiding this comment.
Most standard separators already taken by some options, I saw there was , and maybe ; in upcoming dx8 implementation. : already used by d3d9.forceAspectRatio.
Could be whitespace, but copy-pasting something from dxvk.conf or web will not work, e.g DXVK_CONFIG="dxvk.hud = full" "user friendly" vs DXVK_CONFIG="dxvk.hud=full" with strict (whitespace separator) variant.
Just random choice, to be honest.
There was a problem hiding this comment.
I think ; should be reserved as a separator and not be allowed in option values then. I'd rather change this on the d3d8 side than introduce a weird separator here.
There was a problem hiding this comment.
fine by me, changed it to ;
There was a problem hiding this comment.
d8vk only uses , and : AFAIK, so ; should be perfectly safe to use here.
Lazy-ass implementation
#used as separator;used as separatorDXVK_CONFIG="dxvk.hud=full#dxvk.blah = blah;blah:blah,#"DXVK_CONFIG="dxvk.hud = full; dxvk.blah=blah"Note:
DXVK_HUDvariable still have higher priority thandxvk.confandDXVK_CONFIG#act as comment now (same as indxvk.conf)e.g.
DXVK_CONFIG="#Show compiler; dxvk.hud = compiler; #dxvk.blah=blah"Lets call it feature.
Closes: #2894