Improve shims #101
Improve shims #101
Conversation
src/Map.ts
Outdated
| values(): IterableIterator<V>; | ||
| } | ||
|
|
||
| let ShimMap: MapConstructor; |
There was a problem hiding this comment.
Can you let ShimMap: MapConstructor = global.Map;
Then replace if no es6-map and then just export default ShimMap;?
|
breaking change Several of our collection shims didn't include |
|
breaking change it is also necessary to either target |
src/Promise.ts
Outdated
| * @borrows Promise#then as Promise#then | ||
| */ | ||
| export class Promise<T> implements Thenable<T> { | ||
| global.Promise = ShimPromise = <any> class Promise<T> implements Thenable<T> { |
There was a problem hiding this comment.
Why do you need to cast to any here?
Type: feature
The following has been addressed in the PR:
Description:
This PR will improve our shims, allowing them to be better integrated with TypeScript types and be able to be reduced dramatically when optimized with
dojo buildand static has flags.It is currently a work in progress.
PromiseandMaphave been refactored.