Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for @dojo/shim #246

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Update for @dojo/shim #246

merged 1 commit into from
Jul 26, 2017

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Jul 7, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This PR are the updates required to support updates to @dojo/shim.

Refs: dojo/shim#101

@kitsonk kitsonk merged commit 0df5aef into dojo:master Jul 26, 2017
@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #246 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   98.95%   98.77%   -0.18%     
==========================================
  Files          24       24              
  Lines        1429     1471      +42     
  Branches      413      430      +17     
==========================================
+ Hits         1414     1453      +39     
- Partials       15       18       +3
Impacted Files Coverage Δ
src/select/Select.ts 98.05% <100%> (+0.01%) ⬆️
src/radio/Radio.ts 97.72% <0%> (-2.28%) ⬇️
src/checkbox/Checkbox.ts 98.07% <0%> (-1.93%) ⬇️
src/slidepane/SlidePane.ts 98.79% <0%> (-1.21%) ⬇️
src/button/Button.ts 100% <0%> (ø) ⬆️
src/titlepane/TitlePane.ts 97.95% <0%> (+0.13%) ⬆️
src/dialog/Dialog.ts 96.87% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467a7e2...4e5293e. Read the comment docs.

@dylans dylans added this to the 2017.07 milestone Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants