Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets v6 migration guide / breaking changes #667

Closed
tomdye opened this issue Feb 25, 2019 · 1 comment
Closed

Widgets v6 migration guide / breaking changes #667

tomdye opened this issue Feb 25, 2019 · 1 comment

Comments

@tomdye
Copy link
Member

tomdye commented Feb 25, 2019

Issue to capture breaking changes and migration guide for v5 -> v6.

Please fill in below, this will form part of a migration guide going forward.


TextInput

Removed

  • invalid
  • labelAfter

Added

  • customValidator?: (value: string) => { valid?: boolean; message?: string; } | void;
  • onValidate?: (valid: boolean | undefined, message: string) => void;
  • leading?: () => DNode;
  • trailing?: () => DNode;
  • helperText?: string;

PRs


Enhanced Text Input

DELETED

PRs


Dialog

Added

  • open class alongside 'root' when dialog is open
  • underlayEnterAnimation/ underlayExitAnimation properties
  • Ability to set any of the enter / exit animations to null to stop any animation from running

PRs


Textarea

Removed

  • labelAfter

Added

  • helperText?: string;

PRs


SplitPane

Removed

  • default collapseWidth of 600. If no collapseWidth is passed it will no longer collapse

PRs


Select

Removed

  • labelAfter

Added

  • helperText?: string

PRs


Toolbar

Added

  • .actions wrapper for toolbar actions which will automatically switch from row to column view when menu is collapsed into slide pane.
  • align option to set the alignment of the embedded SlidePan that is displayed on narrow screens

PRs

@tomdye tomdye changed the title Widgets v6 migration guide Widgets v6 migration guide / breaking changes Mar 12, 2019
@tomdye tomdye mentioned this issue Apr 11, 2019
@tomdye tomdye added the dojo-6.0 label May 3, 2019
@agubler
Copy link
Member

agubler commented Nov 21, 2019

@tomdye can this be closed?

@agubler agubler closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants