Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

676: Merge enhanced / standard text inputs #680

Merged
merged 5 commits into from
Mar 11, 2019

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Mar 8, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

  • removes enhanced-text-input
  • adds leading / trailing properties to text-input
  • removes labelAfter property as does not make sense with helperText
  • moves most of the separate render functions into the main render

Resolves #676

@tomdye tomdye changed the title widgets-676: Merge text inputs 676: Merge text inputs Mar 8, 2019
@tomdye tomdye changed the title 676: Merge text inputs 676: Merge enhanced / standard text inputs Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #680 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   99.01%   98.97%   -0.04%     
==========================================
  Files          44       43       -1     
  Lines        3335     3308      -27     
  Branches      921      914       -7     
==========================================
- Hits         3302     3274      -28     
- Misses         33       34       +1
Impacted Files Coverage Δ
src/text-input/index.ts 100% <100%> (ø) ⬆️
src/split-pane/index.ts 98.96% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d8072...9056945. Read the comment docs.

@tomdye tomdye merged commit 14bcab5 into dojo:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants