693 - Add null option to dialog animations #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdye
force-pushed
the
dialog-animation-fix
branch
from
851db64 to
7730368
Compare
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 45 45
Lines 3344 3342 -2
Branches 927 926 -1
==========================================
- Hits 3312 3310 -2
Misses 32 32
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=========================================
Coverage ? 98.98%
=========================================
Files ? 45
Lines ? 3344
Branches ? 928
=========================================
Hits ? 3310
Misses ? 34
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
Description:
Adds option to pass
nullas the enter / exit animation for dialog / underlay. This will prevent the enter / exit animation from running.Issue: #693
Resolves #693