Update Dialog to use latest themeable mixin #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdye
changed the title
Codecov Report@@ Coverage Diff @@
## master #15 +/- ##
======================================
- Coverage 100% 0% -100%
======================================
Files 2 2
Lines 26 28 +2
Branches 13 14 +1
======================================
- Hits 26 0 -26
- Misses 0 28 +28
Continue to review full report at Codecov.
|
bitpshr
reviewed
Feb 2, 2017
| export const close: string; | ||
| export default { | ||
| classes: { | ||
| main: 'main', |
There was a problem hiding this comment.
Was this generated using grunt-dojo2? I'm confused by this. It's in a .d.ts file, but is an actual module. It also doesn't look like the module maps generated class names? I'm probably missing something.
|
Have this been superseded by #19? |
|
Closing as has been superseded by #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Example of using the new
themeableimplementation.Depends upon:
Needs
widget-coredependency updating to latest version