Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ArgentX and Braavos wallets in starknet-react-app #203

Closed
wants to merge 20 commits into from
Closed

Add support for ArgentX and Braavos wallets in starknet-react-app #203

wants to merge 20 commits into from

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented May 14, 2024 •
edited
Loading

Introduced Changes

  • Updated useBurnerManager to accept a null burnerManager instance.
  • Added a mechanism to send fee tokens back to the master account when deleting a burner.
  • Renamed BurnerAccount interface to BurnerManagerHook.
  • Updated starknet-react-app for working with ArgentX and Braavos wallets.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Added a dedicated CI job for new examples
  • Performed self-review of the code

@Matth26 Matth26 changed the title starknet-react-app repo works with ArgentX and Braavos wallets Add support for ArgentX and Braavos wallets in starknet-react-app May 14, 2024
@Matth26 Matth26 mentioned this pull request May 14, 2024
Merged
10 tasks
Matth26 added 13 commits May 14, 2024 16:43
@Matth26
feat: add readme to explain how to create an argentx account on katana
008297c
@Matth26
feat: add optional transactionDetails parameter to all transaction calls
ded34c8
@Matth26
fix: adjust emptyAccount function to handle maxFee deduction
c5f76d4
@Matth26
fix: correct balance fetching + add support for Sepolia network
8c523f8
@Matth26
fix: resolve typescript error in Balance component
df79f7a
@Matth26
fix: typescript error in create-burner package
1b7bd72
@Matth26
fix: script mismatch
d1ca995
@Matth26
feat: react-app example up to date with new create-burner
3c7e101
@Matth26
feat: update react-pwa-app example with new create-burner
c31e27c
@Matth26
feat: examples are working with new create-burner package
353f26f
@Matth26
fix: test for create-burner are working
47aae3c
@Matth26
fix: test why tests are working locally but not on ci
6afd4ff
@Matth26
fix: account is not emptied if maxFee is 0 or undefined
e28dfda
@Matth26 Matth26 marked this pull request as ready for review May 22, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matth26 @ponderingdemocritus