Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katana and ArgentX wallet #1958

Merged
merged 7 commits into from
May 24, 2024
Merged

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented May 14, 2024

Description

This PR includes the following fixes to support connecting an ArgentX wallet with the local Katana environment:

  • Path Update: Corrected a wrong path in the declare-argent-account.sh script.
  • CORS Headers: Added allowed headers to the CORS layer to avoid a CORS policy error when the ArgentX wallet tries to initiate a transaction.

Related issue

This is required to run the starknet-react-app on katana: dojoengine/dojo.js#203

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.96%. Comparing base (a095ccf) to head (412c636).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
- Coverage   69.80%   67.96%   -1.84%     
==========================================
  Files         313      318       +5     
  Lines       35526    37093    +1567     
==========================================
+ Hits        24800    25212     +412     
- Misses      10726    11881    +1155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added katana This issue is related to Katana contributor labels May 15, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matth26 thanks for the proposal here, looks good to me with a minor changes.

@kariy any additional thoughts?

crates/katana/rpc/rpc/src/lib.rs Outdated Show resolved Hide resolved
@glihm glihm marked this pull request as ready for review May 23, 2024 21:31
@glihm glihm merged commit 35ca974 into dojoengine:main May 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants