Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #49: Preview own unpublished permission #12

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Issue #49: Preview own unpublished permission #12

merged 14 commits into from
Nov 21, 2024

Conversation

donquixote
Copy link
Owner

@donquixote donquixote changed the base branch from main to 1.x November 12, 2024 02:46
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch from eae37df to 9d9134f Compare November 12, 2024 02:55
@donquixote donquixote mentioned this pull request Nov 12, 2024
Closed
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch 3 times, most recently from 8dfcbc8 to deb0142 Compare November 12, 2024 14:49
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch from deb0142 to 2fb93df Compare November 12, 2024 15:33
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch from 2fb93df to 4da09bb Compare November 12, 2024 15:42
AaronGilMartinez
AaronGilMartinez requested changes Nov 19, 2024
View reviewed changes
src/CollaboraMediaPermissions.php Show resolved Hide resolved
tests/src/Kernel/CollaboraMediaAccessTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CollaboraMediaAccessTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/CollaboraMediaAccessTest.php Show resolved Hide resolved
tests/src/Kernel/CollaboraMediaAccessTest.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
collabora_online.module Show resolved Hide resolved
collabora_online.module Outdated Show resolved Hide resolved
tests/src/Kernel/CollaboraMediaAccessTest.php Outdated Show resolved Hide resolved
collabora_online.module Show resolved Hide resolved
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch from 7b4b7d5 to 70fed43 Compare November 20, 2024 09:37
@donquixote
Issue CollaboraOnline#49: Introduce new 'preview own unpublished ...'…
55ab297 
… permission.
@donquixote
Issue CollaboraOnline#49: Drop the old functional tests for access an…
f010301 
…d permissions.
@donquixote
Issue CollaboraOnline#49: Remove left-over $negate parameter in test …
486e43f 
…methods.
@donquixote
Issue CollaboraOnline#49: Remove assertBasicAssumptions(), it is not …
d29503d 
…needed.
@donquixote
Issue CollaboraOnline#49: Introduce assertSameYaml() method.
a41a1a4
@donquixote
Issue CollaboraOnline#49: Rework the CollaboraMediaAccessTest, using …
3a2cc68 
…separate assertions.
@donquixote
Issue CollaboraOnline#49: Remove recommendation line in the README.
22ad305
@donquixote
Issue CollaboraOnline#49: Use ::allowedIfHasPermission() to avoid a c…
35d11b3 
…ustom reason string.
@donquixote
Issue CollaboraOnline#49: Remove redundant ->cachePerPermission() whe…
bf2c338 
…n ->cachePerUser() is already present.
@donquixote donquixote force-pushed the issue-49-preview-own-unpublished branch from ee196e1 to bf2c338 Compare November 20, 2024 12:08
@AaronGilMartinez AaronGilMartinez merged commit b27c925 into 1.x Nov 21, 2024
3 checks passed
@AaronGilMartinez AaronGilMartinez deleted the issue-49-preview-own-unpublished branch November 21, 2024 09:38
AaronGilMartinez added a commit that referenced this pull request Nov 25, 2024
@AaronGilMartinez
Merge pull request #12 from donquixote/issue-49-preview-own-unpublished
340b3b4 
Issue CollaboraOnline#49: Preview own unpublished permission
AaronGilMartinez added a commit that referenced this pull request Nov 25, 2024
@AaronGilMartinez
Merge pull request #12 from donquixote/issue-49-preview-own-unpublished
75abe93 
Issue CollaboraOnline#49: Preview own unpublished permission
AaronGilMartinez added a commit that referenced this pull request Nov 25, 2024
@AaronGilMartinez
Merge pull request #12 from donquixote/issue-49-preview-own-unpublished
f00f6aa 
Issue CollaboraOnline#49: Preview own unpublished permission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronGilMartinez AaronGilMartinez AaronGilMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donquixote @AaronGilMartinez