Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use individual file timestamps for copy_shaders #526

Closed
wants to merge 3 commits into from

Conversation

alandtse
Copy link
Collaborator

No description provided.

@alandtse alandtse requested a review from FlayaN September 14, 2024 23:13
@alandtse
Copy link
Collaborator Author

@FlayaN can you make sure this looks right to you?

@alandtse alandtse marked this pull request as draft September 14, 2024 23:14
@alandtse
Copy link
Collaborator Author

Issue I ran into is that it complaints of an existing .rule file. Not sure where that comes from.

@FlayaN
Copy link
Collaborator

FlayaN commented Sep 21, 2024

@FlayaN can you make sure this looks right to you?

A weird review but I created a PR with some details here :P alandtse#4

Issue I ran into is that it complaints of an existing .rule file. Not sure where that comes from.

Fixed that in my PR, added some details why that happens (short answer is that the subfolder of the auto-deploy folder is not always unique, always ends with /Data and then choosing Data as the name for both of them and causes a duplicate rule file)

CMakeLists.txt Show resolved Hide resolved
@alandtse
Copy link
Collaborator Author

Thanks. It's possible I asked an ai and didn't really think through all changes. . .

@alandtse
Copy link
Collaborator Author

Ok, I just realized the issue is all I'm doing it changing what is copied into the aio directory. There's a whole another issue where it just copies everything from aio to the deploy targets. I was trying to solve filewatcher having to rebuild EVERYTHING. But that's way too much work for me.

I'm going to open an issue and hopefully someone can fix it.

@alandtse alandtse closed this Sep 21, 2024
@alandtse
Copy link
Collaborator Author

Basically the issue all boils down to THIS deleting and recreating the directory.
COMMAND ${CMAKE_COMMAND} -E copy_directory "${AIO_DIR}/Shaders" "${DEPLOY_TARGET}/Shaders"

@alandtse alandtse deleted the file_timestamps branch September 21, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants