-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failure-exporter limited to only 50 results #304
Comments
hi @rmarting yes this definitely looks like a bug to me. It appears that at one point we did add an optional PROJECT propery, but we never implemented it. https://github.com/konveyor/pelorus/blob/master/exporters/failure/app.py#L31 |
@etsauer I took some time to create a PR that could improve this issue in a simple way. I am not an python expert developer, however I think this first approach could resolve it. For my use case, it is working as expected and my Pelorus platform is getting the failure rates for the projects wanted. HTH. |
#308 adds support for |
I'm not familiar with JIRA client in Python, however MAX_RESULTS would not be a proper fix as this number is limited by JIRA API itself. Some kind of implementation of paging based on ResultList would be needed. |
JIRA api allows to pull all issues at once, but in our case we want to get subsequent results for two reasons: - some users were reporing problems gathering more then 100 results in one query. - during collection we present feedback to the user that operation is ongoing. As part of this change also the requested data was limited to the data required by pelorus failure exporters, which is summary,labels,created,resolutiondate
* Test to cover JIRA token and password authentication. Added test which checks for the deprecated password authentication. JIRA uses same method to authenticate in the cloud jira instance for both deprecated password authentication and token based auth. This may lead to the situation where wrong API key is actually considered password and then failure exporter is presenting deprecation error. This change also moves connection func to separate private one for easy testing and readibility + may in the future include more sophisticated auth methods. Added proper headers to the files which were modified. * Fix issue #278 - failure pod crashing We should log error rather then crash pod if JIRA is missing type required by failure exporter. JIRA type may be added after pelorus deployment.
Testing the integration with Jira Atlassian I found that exporter is limited to only 50 results.
Checking the log of failure-exporter pod you could see that the Query API endpoint add variables to limit the maximum number of results:
The number of issues found is limite to only 50 entries, but my Jira instance manages hundred of projects with thousands of issues. In my case, the issues that I want to match in Pelorus do not appear in the results, so the Failure Rate metric is not updated for my use case.
How could I set up that value? It could be great to allow to setup the maximum number of issues, or at least execute that query for each project created in Jira. Other idea could be allow to set up the projects in Jira to extract metrics.
Maybe adding some properties in the deployment such as:
The text was updated successfully, but these errors were encountered: