Fix for #304 to allow JIRA obtain more then 50 results #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
openshift-ci
bot
added
the
needs-rebase
Added test which checks for the deprecated password authentication. JIRA uses same method to authenticate in the cloud jira instance for both deprecated password authentication and token based auth. This may lead to the situation where wrong API key is actually considered password and then failure exporter is presenting deprecation error. This change also moves connection func to separate private one for easy testing and readibility + may in the future include more sophisticated auth methods. Added proper headers to the files which were modified.
openshift-ci
bot
removed
the
needs-rebase
We should log error rather then crash pod if JIRA is missing type required by failure exporter. JIRA type may be added after pelorus deployment.
|
I think this should have an accompanying unit and/or integration test, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA api allows to pull all issues at once, but in our case we want to get subsequent results for two reasons:
- some users were reporing problems gathering more then 100 results in one query.
- during collection we present feedback to the user that operation is ongoing.
As part of this change also the requested data was limited to the data required by pelorus failure exporters, which is summary,labels,created,resolutiondate
Fixes #304
Depends on #424 #425
@redhat-cop/mdt