Extract image SHAs from status.containerStatuses as well as spec.containers

[KevinMGranger]

Behavior Changes

The deploytime exporter will now check a pod's status.containerStatuses for image IDs as well.

Linked Issues?

resolves #330

Testing Instructions

I'm planning on adding a simple mock for our deploytime exporter as well, which will have some images that don't have the ID in their spec.

@redhat-cop/mdt

Remaining Work

• I need to see if pod.status.containerStatuses might list sidecars from MutatingAdmissionControllers (e.g. from Istio / Service Mesh), which we wouldn't want to count. It's also possible that those are already included in spec.containers, which would be a separate issue.
• add a unit test / address new unit test failures
• [ ] I need to add the mock as mentioned above.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[KevinMGranger]

Yes, sidecars will show up and be counted in the deploytime metric. This happens in both the spec and the status.

However, this is a tricky problem to solve overall-- a commit in a repo could change some config-as-code that affects the sidecar, meaning the metric would be valid.

In any case, since this is an existing issue, that's separate from this PR.

[etsauer]

Bump. Any updates on this?

[KevinMGranger]

@etsauer the update is that I had a nice vacation and am back to working on this today. All that's left is to add / check the mocked API for testing this, and investigate the unit test failure that CI turned up.

[etsauer]

@KevinMGranger 🤣 welcome back!

[KevinMGranger]

I forgot that we only have mocks for committime for now.

Mocking this can come later-- the unit test should be sufficient.

[KevinMGranger]

Hmm, looks like our python version pinning is complaining about the new version. @mpryc, is there a reason we restricted the patch version of the python version?

[mpryc]

@KevinMGranger there is not, I think it's safe to include the removal of patch in this PR.

[etsauer]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etsauer, KevinMGranger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KevinMGranger,etsauer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment