Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract image SHAs from status.containerStatuses as well as spec.containers #395

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Extract image SHAs from status.containerStatuses as well as spec.containers #395

merged 4 commits into from
Apr 6, 2022

Commits on Apr 5, 2022

  1. Extract image SHAs from status.containerStatuses as well as spec.cont… 

    …ainers
    @KevinMGranger
    KevinMGranger committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cb6ec8f View commit details
    Browse the repository at this point in the history

  2. Remove comment about sidecar SHAs. 

    See dora-metrics#395 (comment)
for details.
    @KevinMGranger
    KevinMGranger committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cdffb0f View commit details
    Browse the repository at this point in the history

  3. Make DeployTimeMetric hashable for the sake of testing (since order d… 

    …oes not matter)
    @KevinMGranger
    KevinMGranger committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    44778f6 View commit details
    Browse the repository at this point in the history

  4. Add containerStatus-only case to deploytime unit test

    @KevinMGranger
    KevinMGranger committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6b3e734 View commit details
    Browse the repository at this point in the history