Better error handling for unknown output (#675)

This PR makes it easier to debug when an output id is used but not present within the dataflow output list of a node.
dora-rs · Oct 7, 2024 · 7d93fe6 · 7d93fe6
2 parents 6f7b030 + 60496e6
commit 7d93fe6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apis/rust/node/src/node/mod.rs b/apis/rust/node/src/node/mod.rs
@@ -253,7 +253,7 @@ impl DoraNode {
  self.handle_finished_drop_tokens()?;
 
  if !self.node_config.outputs.contains(&output_id) {
- eyre::bail!("unknown output");
+ eyre::bail!("unknown dora node output `{output_id}` called by `send_output`. Double-check if this output is defined within your dataflow YAML file.",);
  }
  let metadata = Metadata::from_parameters(self.clock.new_timestamp(), type_info, parameters);
 

diff --git a/examples/echo/dataflow.yml b/examples/echo/dataflow.yml
@@ -11,7 +11,7 @@ nodes:
  build: pip install -e ../../node-hub/dora-echo
  path: dora-echo
  inputs:
- input: terminal-input/data
+ echo: terminal-input/data
  outputs:
  - echo