Skip to content

Commit

Permalink
Use picomatch + impl followups from #48
Browse files Browse the repository at this point in the history
  • Loading branch information
dorny committed Nov 8, 2020
1 parent 550eb49 commit 52cf00c
Show file tree
Hide file tree
Showing 7 changed files with 203 additions and 2,227 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v2.5.2
- [Add support for multiple patterns when using file status](https://github.com/dorny/paths-filter/pull/48)
- [Use picomatch directly instead of micromatch wrapper](https://github.com/dorny/paths-filter/pull/49)

## v2.5.1
- [Improved path matching with micromatch](https://github.com/dorny/paths-filter/pull/46)

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ doesn't allow this because they doesn't work on a level of individual jobs or st
For more scenarios see [examples](#examples) section.
## Notes:
- Paths expressions are evaluated using [micromatch](https://github.com/micromatch/micromatch) library.
- Paths expressions are evaluated using [picomatch](https://github.com/micromatch/picomatch) library.
Documentation for path expression format can be found on project github page.
- Micromatch [dot](https://github.com/micromatch/micromatch#options) option is set to true.
- Micromatch [dot](https://github.com/micromatch/picomatch#options) option is set to true.
Globbing will match also paths where file or folder name starts with a dot.
- It's recommended to quote your path expressions with `'` or `"`. Otherwise you will get an error if it starts with `*`.
- Local execution with [act](https://github.com/nektos/act) works only with alternative runner image. Default runner doesn't have `git` binary.
- Use: `act -P ubuntu-latest=nektos/act-environments-ubuntu:18.04`


# What's New
- Paths expressions are now evaluated using [micromatch](https://github.com/micromatch/micromatch) library
- Paths expressions are now evaluated using [picomatch](https://github.com/micromatch/picomatch) library
- Support workflows triggered by any event
- Fixed compatibility with older (<2.23) versions of git
- Support for tag pushes and tags as a base reference
Expand Down
2 changes: 1 addition & 1 deletion __tests__/filter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ describe('matching specific change status', () => {
expect(match.addOrModify).toEqual(files)
})

test.only('matches when using an anchor', () => {
test('matches when using an anchor', () => {
const yaml = `
shared: &shared
- common/**/*
Expand Down
Loading

0 comments on commit 52cf00c

Please sign in to comment.