feat: Add support for multiple patterns when using file status #48
Conversation
This adds support for using multiple patterns when checking for file status (added, modified, deleted) and as a result also allows you to use YAML anchors.
| @@ -165,6 +165,20 @@ describe('matching specific change status', () => { | |||
| const match = filter.match(files) | |||
| expect(match.addOrModify).toEqual(files) | |||
| }) | |||
|
|
|||
| test.only('matches when using an anchor', () => { | |||
There was a problem hiding this comment.
Please remove the .only modifier so all tests are executed
There was a problem hiding this comment.
Oops, forgot to remove this!
| @@ -78,7 +78,7 @@ export class Filter { | |||
|
|
|||
| if (typeof item === 'object') { | |||
| return Object.entries(item).map(([key, pattern]) => { | |||
| if (typeof key !== 'string' || typeof pattern !== 'string') { | |||
| if (typeof key !== 'string' || (typeof pattern !== 'string' && !Array.isArray(pattern))) { | |||
There was a problem hiding this comment.
This basically tricks the typescript type system.
pattern is declared as string but it will be actually array of strings.
Micromatch library also accepts array of string but this signature is not documented there.
It's definitely just a documentation issue. matcher method actually delegates to picomatch() which indeed accepts string or array of strings.
To keep it simple. Let's leave it as it is and I will do some cleanup afterwards.
|
Thank You 👍 |
This adds support for using multiple patterns when checking for file status (added, modified, deleted) and as a result also allows you to use YAML anchors.