-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude files or dir #106
Comments
Ignoring is supporting by picomatch, so should be possible in theory? |
I ended up forking and replacing src:
- 'src/**/*.ts'
- '!src/**/*.test.ts' |
I've worked around this with an extra bash step:
You need The idea is that you get the list of changed files, and whatever line match your sed expression gets removed from such list (the ignored files). If no lines are left, it means you only had ignored files been modified (OTHER_FILES_CHANGED=false), otherwise not ignored files were modified (OTHER_FILES_CHANGED=true). Then you check in the if statement of the next job which one happened. |
Currently this causes all integration tests to run on common dependabot changes to `lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests also fail due to dependabot not having access to secrets but that is being addressed separately; the primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk. I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible due to a lack of support by the paths-filter action (dorny/paths-filter#106). Upon reflection, I think it is is unlikely that core changes will cause integration test failures that don't also cause other test failures so my proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the contrary, we can add it back. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Currently this causes all integration tests to run on common dependabot changes to `lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests also fail due to dependabot not having access to secrets but that is being addressed separately; the primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk. I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible due to a lack of support by the paths-filter action (dorny/paths-filter#106). Upon reflection, I think it is is unlikely that core changes will cause integration test failures that don't also cause other test failures so my proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the contrary, we can add it back. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Currently this causes all integration tests to run on common dependabot changes to `lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests also fail due to dependabot not having access to secrets but that is being addressed separately; the primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk. I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible due to a lack of support by the paths-filter action (dorny/paths-filter#106). Upon reflection, I think it is is unlikely that core changes will cause integration test failures that don't also cause other test failures so my proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the contrary, we can add it back. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Currently this causes all integration tests to run on common dependabot changes to `lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests also fail due to dependabot not having access to secrets but that is being addressed separately; the primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk. I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible due to a lack of support by the paths-filter action (dorny/paths-filter#106). Upon reflection, I think it is is unlikely that core changes will cause integration test failures that don't also cause other test failures so my proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the contrary, we can add it back. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
hey,
it is possible to use it with exclude dir?
like any why do what you need to do?
steps.filter.outputs.src == 'true' || steps.filter.outputs.ignore == 'true'
The text was updated successfully, but these errors were encountered: